changeset 874:fe6c3446b55d v4.3

req: use const char * for cat/tag/feed/fmt members There is no reason for these to be writable. Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
author Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
date Wed, 26 Jul 2017 00:00:20 +0300
parents 34cb91ba1552
children 279d3a6d80c3
files req.c req.h tag.c
diffstat 3 files changed, 10 insertions(+), 10 deletions(-) [+]
line wrap: on
line diff
--- a/req.c	Tue Jul 25 17:49:52 2017 +0300
+++ b/req.c	Wed Jul 26 00:00:20 2017 +0300
@@ -425,7 +425,7 @@
 	     cur;
 	     cur = nvlist_next_nvpair(req->request_qs, cur)) {
 		char *name, *val;
-		char **cptr;
+		const char **cptr;
 		int *iptr;
 
 		iptr = NULL;
@@ -490,7 +490,7 @@
  */
 static bool switch_content_type(struct req *req)
 {
-	char *fmt = req->args.feed;
+	const char *fmt = req->args.feed;
 	int page = req->args.page;
 
 	const char *content_type;
--- a/req.h	Tue Jul 25 17:49:52 2017 +0300
+++ b/req.h	Wed Jul 26 00:00:20 2017 +0300
@@ -71,9 +71,9 @@
 	int preview;
 	int admin;
 	int comment;
-	char *cat;
-	char *tag;
-	char *feed;
+	const char *cat;
+	const char *tag;
+	const char *feed;
 };
 
 struct req {
@@ -108,7 +108,7 @@
 
 	struct vars vars;
 
-	char *fmt;		/* format (e.g., "html") */
+	const char *fmt;	/* format (e.g., "html") */
 
 	struct {
 		int index_stories;
@@ -133,8 +133,8 @@
 extern int R301(struct req *req, const char *url);
 
 extern int blahg_archive(struct req *req, int m, int paged);
-extern int blahg_category(struct req *req, char *cat, int page);
-extern int blahg_tag(struct req *req, char *tag, int paged);
+extern int blahg_category(struct req *req, const char *cat, int page);
+extern int blahg_tag(struct req *req, const char *tag, int paged);
 extern int blahg_comment(struct req *req);
 extern int blahg_index(struct req *req, int paged);
 extern int blahg_story(struct req *req, int p, bool preview);
--- a/tag.c	Tue Jul 25 17:49:52 2017 +0300
+++ b/tag.c	Wed Jul 26 00:00:20 2017 +0300
@@ -105,12 +105,12 @@
 	return 0;
 }
 
-int blahg_tag(struct req *req, char *tag, int page)
+int blahg_tag(struct req *req, const char *tag, int page)
 {
 	return __tagcat(req, tag, page, "{tagindex}", true);
 }
 
-int blahg_category(struct req *req, char *cat, int page)
+int blahg_category(struct req *req, const char *cat, int page)
 {
 	uint32_t catn;