changeset 94:1235adf7e449

common: make a note of improper return value within connsvc The caller expects an errno on error. Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
author Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
date Sat, 17 Oct 2015 10:39:07 -0400
parents 7ff7b213a3fc
children 17a1cd072c43 c28529eb6fc7
files src/common/connsvc.c
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/common/connsvc.c	Sat Oct 17 10:39:06 2015 -0400
+++ b/src/common/connsvc.c	Sat Oct 17 10:39:07 2015 -0400
@@ -147,7 +147,7 @@
 	snprintf(strport, sizeof(strport), "%d", port);
 
 	if (getaddrinfo(host, strport, &hints, &res))
-		return -1;
+		return -1; /* XXX: should return errno */
 
 	for (p = res; p; p = p->ai_next) {
 		struct sockaddr_in *ipv4;