# HG changeset patch # User Josef 'Jeff' Sipek # Date 1552945835 14400 # Node ID 2735e0d2f0b1f887ad293bad38b0b95900fc9c57 # Parent 7cd40d019de4cd6755060ac84063ff499e1c1bc6 cbor: remove const from cbor_unpack_blob data argument's type Since we will be "returning" a newly malloc'd buffer, there is no reason for us prevent the caller from modifying it. Therefore, we should be using a void * instead of const void *. Signed-off-by: Josef 'Jeff' Sipek diff -r 7cd40d019de4 -r 2735e0d2f0b1 fmt_cbor.c --- a/fmt_cbor.c Tue Mar 19 11:48:47 2019 -0400 +++ b/fmt_cbor.c Mon Mar 18 17:50:35 2019 -0400 @@ -585,8 +585,7 @@ return ret; } -int cbor_unpack_blob(struct buffer *buffer, const void **data, - size_t *size) +int cbor_unpack_blob(struct buffer *buffer, void **data, size_t *size) { return -ENOTSUP; } diff -r 7cd40d019de4 -r 2735e0d2f0b1 include/jeffpc/cbor.h --- a/include/jeffpc/cbor.h Tue Mar 19 11:48:47 2019 -0400 +++ b/include/jeffpc/cbor.h Mon Mar 18 17:50:35 2019 -0400 @@ -65,8 +65,7 @@ extern int cbor_unpack_uint(struct buffer *buffer, uint64_t *v); extern int cbor_unpack_nint(struct buffer *buffer, uint64_t *v); extern int cbor_unpack_int(struct buffer *buffer, int64_t *v); -extern int cbor_unpack_blob(struct buffer *buffer, const void **data, - size_t *size); +extern int cbor_unpack_blob(struct buffer *buffer, void **data, size_t *size); extern int cbor_unpack_cstr_len(struct buffer *buffer, char **str, size_t *len); extern int cbor_unpack_str(struct buffer *buffer, struct str **str);